Skip to content

JIT: Properly check spilling around fat pointer calls #116692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

jakobbotsch
Copy link
Member

Fix #116689

@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 14:06
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 16, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #116689 by ensuring the JIT properly spills around fat pointer calls and adds a repro test.

  • Change impStoreToTemp from CHECK_SPILL_NONE to CHECK_SPILL_ALL in importercalls.cpp
  • Add a new regression test (Runtime_116689) with accompanying csproj and source file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/coreclr/jit/importercalls.cpp Switch spill check mode to CHECK_SPILL_ALL for calli temp
src/tests/JIT/Regression/JitBlue/Runtime_116689.csproj New test project file
src/tests/JIT/Regression/JitBlue/Runtime_116689/Runtime_116689.cs New test source exercising fat pointer call spill behavior
Comments suppressed due to low confidence (2)

src/tests/JIT/Regression/JitBlue/Runtime_116689/Runtime_116689.csproj:1

  • The new test project is missing essential properties (e.g., , , ), so it won’t compile. Please add the same settings used by other JIT regression tests.
<Project Sdk="Microsoft.NET.Sdk">

src/tests/JIT/Regression/JitBlue/Runtime_116689/Runtime_116689.cs:9

  • The method decorated with [Fact] returns an int, but xUnit requires a void or Task return. Update the signature and add an Assert for the expected result, or remove xUnit and follow the established JIT test pattern (Main returning int).
[Fact]

@jakobbotsch
Copy link
Member Author

PTAL @dotnet/jit-contrib

@jakobbotsch jakobbotsch requested a review from a team June 16, 2025 16:52
@jakobbotsch jakobbotsch merged commit 0dea0b5 into dotnet:main Jun 17, 2025
116 checks passed
@jakobbotsch jakobbotsch deleted the fix-116689 branch June 17, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Incorrect spilling around fat pointer calls
2 participants