Add interpreter pipeline #116844
Open
Add interpreter pipeline #116844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 20, 2025
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eduardo-vp
force-pushed
the
interpreter-tests-ci
branch
from
42abcf8 to
af49e63
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.
- Extended
helixpublishwitharcade.projto define and consume a_RunInterpreterMSBuild property and emit Helix pre-commands. - Created
eng/pipelines/coreclr/interpreter.ymlto build CoreCLR in debug/release/checked configurations and invoke tests withrunInterpreter: true. - Updated common templates (
send-to-helix-step.yml,run-test-job.yml) to accept and forward therunInterpreterparameter.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/Common/helixpublishwitharcade.proj | Added _RunInterpreter property and corresponding Windows/Linux Helix pre-commands. |
| eng/pipelines/coreclr/interpreter.yml | New pipeline file for interpreter-based builds and test runs. |
| eng/pipelines/common/templates/runtimes/send-to-helix-step.yml | Added runInterpreter parameter and mapped it to _RunInterpreter. |
| eng/pipelines/common/templates/runtimes/run-test-job.yml | Introduced runInterpreter parameter with default false and propagated it. |
Comments suppressed due to low confidence (1)
eng/pipelines/coreclr/interpreter.yml:16
- [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
- template: /eng/pipelines/common/platform-matrix.yml
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Still testing - adding the changes to the ci.yml pipeline so it's easier to test, will eventually undo the changes]
Adding a pipeline that runs pri1 tests using the interpreter.