Override type load limit in AssemblyBinder::GetNameForDiagnosticsFromManagedALC #116900
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ManagedALC GetNameForDiagnosticsFromManagedALC calls into user code that can trigger more type loading as side-effect.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an override for the type load limit in AssemblyBinder::GetNameForDiagnosticsFromManagedALC to mitigate potential side effects from user code that can trigger additional type loading.
- Introduces a call to OVERRIDE_TYPE_LOAD_LEVEL_LIMIT with CLASS_LOADED as an argument.
- Ensures that user code execution is safely constrained by overriding the type load limit.
Comments suppressed due to low confidence (1)
src/coreclr/vm/assemblybinder.cpp:177
- [nitpick] Consider adding a clarifying comment explaining why OVERRIDE_TYPE_LOAD_LEVEL_LIMIT is applied here, to improve code maintainability and clarify its purpose in mitigating side-effects from invoking user code.
OVERRIDE_TYPE_LOAD_LEVEL_LIMIT(CLASS_LOADED);
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
|
Found while testing #116354. It manifests as type load lever contract violation when turning tracing on and off a lot. |
This was referenced Jun 22, 2025
elinor-fung
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetNameForDiagnosticsFromManagedALC calls into user code that can trigger more type loading as side-effect.