-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Do not preserve enumerators in reflection #117345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
MichalStrehovsky/rt-sz#142 (comment) Saves 8KB in reflection. Not change in other workloads, as they have either using |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
...Private.CoreLib/src/System/Reflection/Runtime/CustomAttributes/RuntimeCustomAttributeData.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This single line will cause all enumerators to be preserved when reflection is used, for every generic instantiation of every collection type.
Although user application may still introduce this, at least it saves for simpler applications.