System.Reflection.CustomAttributeFormatException thrown on a retrieval of derived attribute with overridden property getter #117584
+149
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l of derived attribute with overridden property getter
dotnet-policy-service
bot
added
the
community-contribution
pedrobsaila
requested review from
thaystg,
steveisok and
vitek-karas
as code owners
This was referenced Jul 15, 2025
Open
| @@ -107,7 +107,7 @@ public static Attribute Instantiate(this CustomAttributeData cad) | |||
| for (; ; ) | |||
| { | |||
| PropertyInfo? propertyInfo = walk.GetProperty(name, BindingFlags.Public | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly); | |||
| if (propertyInfo != null) | |||
| if (propertyInfo?.SetMethod is not null) | |||
There was a problem hiding this comment.
Is this logic equivalent to the others, or just equivalent enough to pass the test? What corner cases are we missing in the test that necessitate the more complex logic elsewhere?
There was a problem hiding this comment.
Sorry, I was going to be off for a few days so I did rapidely just enough to pass the test and not let the PR hanging, I fixed it now. The missing condition stops the lookup in base classes early if someone used the new keyword to hide the property instead of overriding it.
dotnet-policy-service
bot
added
the
linkable-framework
This was referenced Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110412
Sorry for the delay, I've been busy these last weeks