Fix the isEmbeddedMaskingCompatible checks #117607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the embedded mask compatibility logic to reflect that mask base sizes should be 2 or 4 (instead of 4 or 8) and adds a new JIT regression test for the updated behavior.
- Renamed and updated the boolean flag and assertions in
gentree.cppto use mask sizes 2 and 4. - Changed the compatibility check to use
tgtMaskBaseSize == 2. - Introduced a new JIT regression test project and test file for
Runtime_117605.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/gentree.cpp | Updated mask base size checks from 4/8 to 2/4 |
| src/tests/JIT/Regression/JitBlue/Runtime_117605/Runtime_117605.csproj | Added project file for the new regression test |
| src/tests/JIT/Regression/JitBlue/Runtime_117605/Runtime_117605.cs | Added the generated JIT regression test implementation |
Comments suppressed due to low confidence (1)
|
CC. @dotnet/jit-contrib for review. This fixes an assert that was showing up in Fuzzlyn |
|
Logged #117612 for the unrelated Arm64 fuzzlyn failure |
This was referenced Jul 14, 2025
Open
EgorBo
reviewed
Jul 15, 2025
src/tests/JIT/Regression/JitBlue/Runtime_117605/Runtime_117605.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 16, 2025
|
/ba-g unrelated android timeout and auth failure which didn't show in previous run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #117605
The mask base size corresponds to the number of elements processed in a V128. This can be
Count(normal vector),1(scalar vector), orCount / n(typically used for conversions; likefloat->doublewhere the counts mismatch between input/output). While the input base size corresponds to the size of the element typeThis means the
inputSizeforV128<ulong>is8while themaskBaseSizeis typically2(because16 / 8 == 2) and the embedded mask checks need to checking for2for the conversion to be safe.