Skip to content

Fix metric tests timeout issue #117630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged

Fix metric tests timeout issue #117630

merged 5 commits into from
Jul 16, 2025

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 14, 2025

Fixes #117226

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 22:38
@tarekgh
Copy link
Member Author

tarekgh commented Jul 14, 2025

/azp list

Copy link

CI/CD Pipelines for this repository:

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout for all remote-invoked metric tests to address intermittent CI timeouts.

  • Adds a shared RemoteInvokeOptions instance with an extended timeout
  • Updates each RemoteInvoke(...).Dispose() call to pass the new timeout options

@tarekgh
Copy link
Member Author

tarekgh commented Jul 14, 2025

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh
Copy link
Member Author

tarekgh commented Jul 14, 2025

/azp run runtime-coreclr jitstress

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh tarekgh added this to the 10.0.0 milestone Jul 14, 2025
@tarekgh tarekgh requested review from ericstj and noahfalk July 14, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: System.Diagnostics.Metrics.Tests.MetricsTests.ThrowingExceptionsFromObservableInstrumentCallbacks
2 participants