Remove IsWatchOS checks for consistency #117653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR removes all OperatingSystem.IsWatchOS() checks to streamline platform consistency and deprecate explicit watchOS handling.
- Dropped watchOS from runner entry logic and platform detection utilities.
- Updated tests, interop layers, and library code to no longer special-case watchOS.
- Aligned
OperatingSystemTests, globalization messaging, and internal platform behaviors accordingly.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RunnerEntryPoint.cs | Removed IsWatchOS from Apple entry-point condition. |
| PlatformDetection.cs | Excluded watchOS from unsupported-native-assets and AppleMobile flags. |
| OperatingSystemTests.cs | Eliminated watchOS entry in OS platform test data. |
| GlobalizationMode.Unix.cs | Dropped watchOS check in ICU load failure logic. |
| msquic.cs | Removed watchOS from SockaddrHasLength predicate. |
| PingTest.cs | No longer excludes watchOS from raw-sockets logic. |
| PathInternal.CaseSensitivity.cs | Excluded watchOS from case-insensitivity detection. |
| Interop.Odbc.cs | ODBC library lookup no longer checks for watchOS. |
davidnguyen-tech
added
area-Infrastructure-mono
os-ios
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 15, 2025
Open
|
/ba-g Infstrastructure problem, timeouts (e.g. tracked in #117714) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
OperatingSystem.IsWatchOS()checks for consistency.Related issues
Fixes #92601