Skip to content

disable multicast tests on AzureLinux #117694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2025
Merged

disable multicast tests on AzureLinux #117694

merged 8 commits into from
Jul 22, 2025

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 16, 2025

related to #115502.

default AZL has firewall that blocks multicast.

@wfurt wfurt requested review from Copilot and a team July 16, 2025 00:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables multicast tests on AzureLinux by introducing a new conditional check that excludes platforms where multicast functionality is not available or blocked. The change consolidates existing platform exclusions and adds AzureLinux to the list of platforms that cannot run multicast tests due to firewall restrictions.

Key Changes:

  • Introduces a new CanRunMulticastTests property that consolidates platform checks for multicast test compatibility
  • Replaces individual ConditionalFact and ActiveIssue attributes with a single unified condition
  • Adds AzureLinux to the list of platforms excluded from multicast tests
Comments suppressed due to low confidence (1)

src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs:20

  • [nitpick] The property name CanRunMulticastTests uses a positive naming convention but is implemented with negation logic. Consider renaming to ShouldSkipMulticastTests or restructuring the logic to avoid double negation for better readability.
        private static readonly bool CanRunMulticastTests = !(PlatformDetection.IsNotWindowsNanoNorServerCore ||

@wfurt wfurt self-assigned this Jul 16, 2025
@wfurt wfurt added the test-run-core Test failures in .NET Core test runs label Jul 16, 2025
@wfurt wfurt added this to the 10.0.0 milestone Jul 16, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ManickaP
Copy link
Member

/ba-g failures unrelated

@wfurt wfurt merged commit 91f4d57 into dotnet:main Jul 22, 2025
79 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Sockets test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants