-
Notifications
You must be signed in to change notification settings - Fork 5.1k
disable multicast tests on AzureLinux #117694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables multicast tests on AzureLinux by introducing a new conditional check that excludes platforms where multicast functionality is not available or blocked. The change consolidates existing platform exclusions and adds AzureLinux to the list of platforms that cannot run multicast tests due to firewall restrictions.
Key Changes:
- Introduces a new
CanRunMulticastTests
property that consolidates platform checks for multicast test compatibility - Replaces individual
ConditionalFact
andActiveIssue
attributes with a single unified condition - Adds AzureLinux to the list of platforms excluded from multicast tests
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs:20
- [nitpick] The property name
CanRunMulticastTests
uses a positive naming convention but is implemented with negation logic. Consider renaming toShouldSkipMulticastTests
or restructuring the logic to avoid double negation for better readability.
private static readonly bool CanRunMulticastTests = !(PlatformDetection.IsNotWindowsNanoNorServerCore ||
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ba-g failures unrelated |
related to #115502.
default AZL has firewall that blocks multicast.