Skip to content

[interp] Forcibly enable intrinsics when we encounter a must-expand call #117727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kg
Copy link
Member

@kg kg commented Jul 16, 2025

Right now when testing individual methods from the startup path with the interpreter a lot of them fail due to stack overflow. This is because we're compiling a must expand intrinsic with the interpreter, which will recurse infinitely.

  • When encountering a must expand intrinsic self-call in an interpreted method, always expand it even if intrinsics are turned off.
  • Clean up a minor edge case in the 'is reference or contains references' intrinsic
  • Remove an alignment assert that is causing failures in the startup path

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 16, 2025
@kg kg marked this pull request as ready for review July 16, 2025 18:09
@kg kg requested review from BrzVlad and janvorli as code owners July 16, 2025 18:09
@kg
Copy link
Member Author

kg commented Jul 16, 2025

The failures on CI don't reproduce locally, it seems like when I run locally the test suite just exits early and is recorded as passing. Looking into it.

@kg kg force-pushed the interp-mustexpand branch from 811e357 to c9feba0 Compare July 17, 2025 04:39
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants