Update BigInteger and Complex to support UTF8 parsing and formatting #117745
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
|
|
||
| public ValueStringBuilder(Span<TChar> initialBuffer) | ||
| { | ||
| Debug.Assert((typeof(TChar) == typeof(Utf8Char)) || (typeof(TChar) == typeof(Utf16Char))); |
There was a problem hiding this comment.
If this is specific to these types that are defined just in System.Runtime.Numerics, and it's only used by System.Runtime.Numerics, we probably shouldn't have the file in Common?
There was a problem hiding this comment.
It's not really specific to the numeric types and is usable by any other scenario using ValueStringBuilder that needs to support UTF-8 as well. So I put it in the place that people can find it if they're making similar changes to other paths in the future.
More ideally we wouldn't need the Utf8Char shim in System.Runtime.Numerics and we could just use byte/char directly. However, we currently need the direct CastFrom/CastTo helpers to ensure the right codegen happens. I think we could probably fix this by special casing CreateFromTruncating in the JIT for the primitive types.
Still need to add tests