Cleanup uses of Interlocked.CompareExchange<object> #117858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by simplifying singleton lazy initialization patterns that previously used verbose Interlocked.CompareExchange<object> implementations. The changes leverage C# 13's implicit backing field feature to create more concise and readable code while maintaining the same thread-safe behavior.
- Replaces verbose property getters with expression-bodied properties using implicit backing fields
- Removes explicit generic type parameters from
Interlocked.CompareExchangecalls where type inference is sufficient - Simplifies one method from property to expression-bodied syntax
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Text.Encoding.CodePages/src/System/Text/SBCSCodePageEncoding.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Text.Encoding.CodePages/src/System/Text/EncoderBestFitFallback.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Text.Encoding.CodePages/src/System/Text/DecoderBestFitFallback.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Text.Encoding.CodePages/src/System/Text/DBCSCodePageEncoding.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlSchemaSet.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Private.CoreLib/src/System/TimeZone.cs | Modernizes InternalSyncObject property using implicit backing field pattern |
| src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/Switch.cs | Modernizes InitializedLock property using implicit backing field pattern |
| src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs | Modernizes SyncRoot property and simplifies GetUnderlyingNativeHandle method |
| src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.CoreCLR.cs | Removes explicit generic type parameter from Interlocked.CompareExchange call |
am11
added
area-System.Threading
and removed
needs-area-label
am11
approved these changes
Jul 20, 2025
stephentoub
approved these changes
Jul 20, 2025
This was referenced Jul 20, 2025
Open
|
/ba-g infrastructure timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.