Skip to content

Run libtests in interpmode1 so it is faster#127076

Merged
BrzVlad merged 1 commit into
dotnet:mainfrom
BrzVlad:fix-clrinterp-libtests
Apr 20, 2026
Merged

Run libtests in interpmode1 so it is faster#127076
BrzVlad merged 1 commit into
dotnet:mainfrom
BrzVlad:fix-clrinterp-libtests

Conversation

@BrzVlad

@BrzVlad BrzVlad commented Apr 17, 2026

Copy link
Copy Markdown
Member

Remove windows runs from the pipeline. Many suites fail with com related tests and windows is not really relevant as a target for now. We still run full runtime tests on windows.

STJ.Tests

  • jit 2min
  • interpmode1 15min
  • interpmode3 >1.5h

This also uncovers a new set of failures that we will need to address

Copilot AI review requested due to automatic review settings April 17, 2026 11:30
@BrzVlad

BrzVlad commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts interpreter library test execution (scenario + pipeline coverage) and fixes a GC safety issue in interpreter async continuation resumption.

Changes:

  • Switches the libraries interpreter Helix scenario from interpmode3 to interpmode1 and updates the associated work item timeout.
  • Updates the libraries-interpreter.yml pipeline to stop scheduling windows_x64 and to run interpmode1.
  • Adds GC interior-pointer protection for resultStorage during AsyncHelpers_ResumeInterpreterContinuationWorker execution.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/libraries/sendtohelixhelp.proj Updates Helix work item timeout logic for interpreter scenario (interpmode1).
src/coreclr/vm/interpexec.cpp Protects resultStorage (interior managed pointer) from becoming stale across GC during interpreter execution.
eng/pipelines/coreclr/libraries-interpreter.yml Adjusts scheduled interpreter-libraries pipeline platforms and scenario (interpmode1).

Remove windows runs from the pipeline. Many suites fail with com related tests and windows is not really relevant as a target for now. We still run full runtime tests on windows.
@BrzVlad BrzVlad force-pushed the fix-clrinterp-libtests branch from d004d8e to 28a51d3 Compare April 20, 2026 05:57
@BrzVlad

BrzVlad commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad BrzVlad changed the title Fix clrinterp libtests Run libtests in interpmode1 so it is faster Apr 20, 2026
@BrzVlad BrzVlad marked this pull request as ready for review April 20, 2026 10:44
Copilot AI review requested due to automatic review settings April 20, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@BrzVlad BrzVlad requested a review from kotlarmilos April 20, 2026 15:43
@BrzVlad BrzVlad assigned janvorli and unassigned janvorli Apr 20, 2026
@BrzVlad BrzVlad requested a review from janvorli April 20, 2026 15:44

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@BrzVlad BrzVlad merged commit 263d5b9 into dotnet:main Apr 20, 2026
169 of 178 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants