-
Notifications
You must be signed in to change notification settings - Fork 5k
Add custom name binding for .Net Configuration. #40422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Internal dictionary created from json/xml for configurations do not honor custom names on the JSON property bindings for class properties. This change adds support.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @maryamariyan |
@maryamariyan Do you know what steps I should take for this PR? Seems like there is a CI/CD issue with installing required prerequisites for the failing tests. |
If you are working on windows is a doc page on requirements for building on windows. A bit more on building and testing. From what I see in the CI results, there is an error on the test project. I think it will repro for you locally:
Also note since you are adding API, the issue page needs to represent API proposal, usage, and the API needs approval as per guideline in API review process. PRs cannot be merged or approved until the API is approved first. We are approaching the 5.0 code complete this week, so chances are this would most probably fall on the 6.0 timeframe because it involves a new API. |
@maryamariyan patched - all the other builds could reference it and the Does this count as a new API? It adds a boolean binding property to the |
Yes it's new API and it's a new feature |
Closing pending another issue to determine whether API is decided upon per request in issue #36010 |
Took a swag at addressing the gap between the Json source and the Binder projects. The Json settings I work with contain names that don't match the setting classes. Those are mapped by
JsonProperty
orDataMember
where a name is given that can be mapped.The binder project, rightfully, doesn't know about Json or any other formats. The one area where it could be built up more is around looking at the attributes associated with the properties of the object it's attempting to bind to the configuration dictionary. This is an attempt to try to just that.
Summary of the changes (Less than 80 chars):
Addresses issue #36010