Skip to content

Disable HttpTelemetry for HTTP 3 requests #40839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

MihaZupan
Copy link
Member

Avoid logging orphaned RequestStart events when using HTTP3, as the Http3 logic is not instrumented with Telemetry.

Contributes to #37428

@MihaZupan MihaZupan added this to the 5.0.0 milestone Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@MihaZupan MihaZupan merged commit 98eecc7 into dotnet:master Aug 16, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants