Skip to content

[Wasm] Standardize console polyfill a bit #48206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 12, 2021

Make the console output from the jsc and sm match the expected format and clean up the logic. Don't switch on json formatting for the browser case until and unless the browser has connected to the xharness test websocket.

@ghost
Copy link

ghost commented Feb 12, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing lewing added the arch-wasm WebAssembly architecture label Feb 12, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Make the console output from the jsc and sm match the expected format and clean up the logic. Don't switch on json formatting for the browser case until and unless the browser has connected to the xharness test websocket.

Author: lewing
Assignees: -
Labels:

arch-wasm

Milestone: -

@ghost
Copy link

ghost commented Feb 14, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Make the console output from the jsc and sm match the expected format and clean up the logic. Don't switch on json formatting for the browser case until and unless the browser has connected to the xharness test websocket.

Author: lewing
Assignees: -
Labels:

arch-wasm, area-System.Console

Milestone: -

@lewing lewing marked this pull request as ready for review February 24, 2021 23:52
@lewing lewing requested a review from marek-safar as a code owner February 24, 2021 23:52
@lewing lewing merged commit 8be118e into dotnet:master Feb 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants