[browser][crypto] Fix Quota Exceeded error

[kjpou1]

Add batched implementation to fix error with quota exceeded limit.

• If the byteLength of array is greater than 65536, throw a QuotaExceededError and terminate the algorithm.
• https://www.w3.org/TR/WebCryptoAPI/#Crypto-method-getRandomValues

Add and/or update tests for exceeding the quota limit of browser set at 65536.

The tests only went up to 65536 so this error was never caught.

A small repo from issue:

Span<byte> data = new byte[ 1024 * 1024 ];
RandomNumberGenerator.Fill( data );

1024 * 1024 = 1048576

Fix #48584

[ghost]

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Add batched implementation to fix error with quota exceeded limit.

• If the byteLength of array is greater than 65536, throw a QuotaExceededError and terminate the algorithm.
• https://www.w3.org/TR/WebCryptoAPI/#Crypto-method-getRandomValues

Add and/or update tests for exceeding the quota limit of browser set at 65536.

The tests only went up to 65536 so this error was never caught.

Fix #48584

Author:	kjpou1
Assignees:	-
Labels:	area-System.Security
Milestone:	-

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Add batched implementation to fix error with quota exceeded limit.

• If the byteLength of array is greater than 65536, throw a QuotaExceededError and terminate the algorithm.
• https://www.w3.org/TR/WebCryptoAPI/#Crypto-method-getRandomValues

Add and/or update tests for exceeding the quota limit of browser set at 65536.

The tests only went up to 65536 so this error was never caught.

Fix #48584

Author:	kjpou1
Assignees:	kjpou1
Labels:	arch-wasm, area-System.Security
Milestone:	-

[kg]

Is there a specific reason why we aren't just writing directly into the wasm heap using views, instead of using these scratch work arrays?

[kjpou1]

Do you mean this one: var wrkArray = new Uint8Array(Module.HEAPU8.buffer, buffer, bufferLength);

That does write into wasm heap.

[kg]

Do you mean this one: var wrkArray = new Uint8Array(Module.HEAPU8.buffer, buffer, bufferLength);

That does write into wasm heap.

I don't think you need wrkArray, you should be able to create small views into the wasm heap and then use crypto.getRandomValues to write directly into the view

[kjpou1]

ok

[kjpou1]

updated to use suggested code from katelyn

[GrabYourPitchforks]

Doesn't line 13 have the potential to integer overflow?

[kg]

Doesn't line 13 have the potential to integer overflow?

It's not an integer, so no. JS can represent integral numbers up to 53 bits in size