-
Notifications
You must be signed in to change notification settings - Fork 5k
Add design document for Mobile runtimeconfig.json host configuration #50744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The main feedback is that the design document should be more affirmative: "this is what the runtime does", not "this is what the runtime should do". Also I think we don't need to talk about the implementation too much (ie, exactly when we parse the file, etc), but we should talk much more about the contract: the name of the task, the names of the parameters, etc. It would be good to add an example of how to use the task. Something like this (but with correct details): <!-- FIXME: I'm not sure what the task name is... use the correct one -->
<UsingTask TaskName="GenerateRuntimeConfigBlobTask"... /> <!-- here we should show how to find the task inside the runtime pack -->
<Target Name="GenerateRuntimeConfigBlob" AfterTargets="XYZ"> <!-- what's the right target to run after/depend on? -->
<GenrateRuntimeConfigBlobTask InputFile="..." OutputFile="..." ReservedProperties="@(...)" />
</Target> And we should describe the behavior of monovm_runtimeconfig_initialize and how embedders should interact with it. Maybe also with a concise example. |
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Contributes to #49237