[mono] win32 implementation of g_get_current_dir #58523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dotnet#56163 The getcwd call is returning the string encoded in system character encoding instead of utf-8. Use native GetCurrentDirectoryW call instead and convert to utf-8.
ghost
added
the
|
Tagging subscribers to this area: Issue DetailsFix #56163 The Use native
|
lambdageek
approved these changes
Sep 1, 2021
|
Can we add a specific test for this? |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1194243207 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56163
The
getcwdcall is returning the string encoded in system characterencoding.
Use native
GetCurrentDirectoryWcall instead and convert to utf-8.