Skip to content

Conversation

@BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Nov 16, 2021

Ideally we would want to compute this set of signatures at compile time.

Fixes #61156

@ghost
Copy link

ghost commented Nov 16, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BrzVlad BrzVlad added the arch-wasm WebAssembly architecture label Nov 16, 2021
@ghost
Copy link

ghost commented Nov 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Ideally we would want to compute this set of signatures at compile time.

Fixes #61156

Author: BrzVlad
Assignees: -
Labels:

arch-wasm

Milestone: -

@lewing
Copy link
Member

lewing commented Nov 16, 2021

Ideally we would want to compute this set of signatures at compile time.

Yeah this is on my list. I'll open an issue to make it clear.

@SamMonoRT
Copy link
Member

cc @lewing - the issue is marked with 6.0.x milestone.

@TheSpydog
Copy link
Contributor

Since filing the original issue (#61156) I've discovered several more unsupported pinvoke signatures in our codebase. I generated the other signatures required for our assembly with wasm-tuner, so should I submit them as a separate PR? Or should I hold off on that in favor of the upcoming change to create the signature set at compile time?

@BrzVlad
Copy link
Member Author

BrzVlad commented Nov 19, 2021

@TheSpydog I think we should include them as part of this PR. Could you please share the cookies/hashes for these signatures ?

@TheSpydog
Copy link
Contributor

Sure, the additional missing signature hashes are as follows:

IIFFFF
IIIIIDII
IIIIIFIII
LIIII

@BrzVlad BrzVlad force-pushed the fix-wasm-pinvoke-sig branch from c3967e2 to 009d7c6 Compare November 22, 2021 11:29
@lewing
Copy link
Member

lewing commented Dec 15, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marek-safar marek-safar merged commit 823ec69 into dotnet:main Dec 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] Specific PInvoke call works with AOT but fails on Interp

7 participants