-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[wasm] Add a new supported signature for pinvokes #61667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Yeah this is on my list. I'll open an issue to make it clear. |
|
cc @lewing - the issue is marked with 6.0.x milestone. |
|
Since filing the original issue (#61156) I've discovered several more unsupported pinvoke signatures in our codebase. I generated the other signatures required for our assembly with wasm-tuner, so should I submit them as a separate PR? Or should I hold off on that in favor of the upcoming change to create the signature set at compile time? |
|
@TheSpydog I think we should include them as part of this PR. Could you please share the cookies/hashes for these signatures ? |
|
Sure, the additional missing signature hashes are as follows: |
c3967e2 to
009d7c6
Compare
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ideally we would want to compute this set of signatures at compile time.
Fixes #61156