Skip to content

Exclude DNNE based test project from armel builds #62486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Dec 7, 2021

Using mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-armel-tizen-20210719212651-8b02f56 container, I have bisected the issue to this commit 78f4fa8. Fix is to exclude DNNE dependent test project from restore and build on armel.

Fixes #62478.
cc @gbalykov, @jkoritzinsky

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Infrastructure-libraries labels Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Using mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-armel-tizen-20210719212651-8b02f56 container, I have bisected the issue to this commit 78f4fa8. Fix is to exclude DNNE dependent test project from restore and build on armel.

cc @gbalykov, @jkoritzinsky

Author: am11
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@gbalykov
Copy link
Member

gbalykov commented Dec 7, 2021

Thanks for quick fix! I'll test on my side too

@@ -46,6 +46,11 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices\tests\DllImportGenerator.Tests\DllImportGenerator.Tests.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetArchitecture)' == 'armel'">
<!-- DllImportGenerator runtime tests depend on DNNE, which does not support armel as we don't officially support it. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "DNNE"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/AaronRobinsonMSFT/DNNE, used as a dependency for GeneratedDllImportAttribute tests.

@jeffschwMSFT
Copy link
Member

cc @jkoritzinsky

@safern
Copy link
Member

safern commented Dec 7, 2021

cc: @AaronRobinsonMSFT

@AaronRobinsonMSFT
Copy link
Member

@am11 What aspect of DNNE doesn't work on armel?

Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me, thanks again

@AaronRobinsonMSFT
Copy link
Member

@am11 What aspect of DNNE doesn't work on armel?

Oh. This doesn't really have anything to do with DNNE but rather the hosting library (that is, nethost), is that it?

@jkoritzinsky
Copy link
Member

Yeah based on the error code, the problem is that we don't ship an apphost pack for armel and DNNE needs the pack for the nethost.

@am11
Copy link
Member Author

am11 commented Dec 7, 2021

This doesn't really have anything to do with DNNE

I basically used this block

<ItemGroup Condition="'$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'arm'">
<!-- DllImportGenerator runtime tests depend on DNNE, which does not support Windows ARM32 as we don't officially support it. -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices\tests\DllImportGenerator.Tests\DllImportGenerator.Tests.csproj" />
and adapted the condition for armel. That comment suggests it has something to do with DNNE. ;)

NETSDK1084 does not tell us the project that failed to restore (re #56623 (comment)).

Luckily, git(1) bisected 2dff7cd in 10 steps and 78f4fa8 is its parent commit on the main branch (https://gist.github.com/am11/d990277911afc29d9e4904df6275094f).

@am11
Copy link
Member Author

am11 commented Dec 11, 2021

@jkoritzinsky, is it good to merge?

@jkoritzinsky
Copy link
Member

Yep

@jkoritzinsky jkoritzinsky merged commit e19619a into dotnet:main Dec 11, 2021
@am11 am11 deleted the feature/armel-build branch December 11, 2021 04:06
@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libraries 7.0 (master) cross build failed for tizen armel
7 participants