-
Notifications
You must be signed in to change notification settings - Fork 5k
Exclude DNNE based test project from armel builds #62486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsUsing
|
Thanks for quick fix! I'll test on my side too |
@@ -46,6 +46,11 @@ | |||
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices\tests\DllImportGenerator.Tests\DllImportGenerator.Tests.csproj" /> | |||
</ItemGroup> | |||
|
|||
<ItemGroup Condition="'$(TargetArchitecture)' == 'armel'"> | |||
<!-- DllImportGenerator runtime tests depend on DNNE, which does not support armel as we don't officially support it. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "DNNE"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/AaronRobinsonMSFT/DNNE, used as a dependency for GeneratedDllImportAttribute
tests.
@am11 What aspect of DNNE doesn't work on armel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked for me, thanks again
Oh. This doesn't really have anything to do with DNNE but rather the hosting library (that is, |
Yeah based on the error code, the problem is that we don't ship an apphost pack for armel and DNNE needs the pack for the nethost. |
I basically used this block runtime/src/libraries/tests.proj Lines 44 to 46 in ae20c2e
Luckily, |
@jkoritzinsky, is it good to merge? |
Yep |
Using
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-armel-tizen-20210719212651-8b02f56
container, I have bisected the issue to this commit 78f4fa8. Fix is to exclude DNNE dependent test project from restore and build on armel.Fixes #62478.
cc @gbalykov, @jkoritzinsky