Skip to content

[wasm] Allow the main.js file to keep it's name #62576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2021

Conversation

pavelsavara
Copy link
Member

This will be useful to be able to have .mjs and .cjs main files, so that NodeJs could load it properly.

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Dec 9, 2021
@pavelsavara pavelsavara added this to the 7.0.0 milestone Dec 9, 2021
@ghost
Copy link

ghost commented Dec 9, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This will be useful to be able to have .mjs and .cjs main files, so that NodeJs could load it properly.

Author: pavelsavara
Assignees: -
Labels:

arch-wasm

Milestone: 7.0.0

@ghost ghost added the area-Build-mono label Dec 9, 2021
@pavelsavara pavelsavara marked this pull request as ready for review December 9, 2021 17:11
@radical
Copy link
Member

radical commented Dec 10, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Dec 10, 2021

cc @thaystg to confirm that this doesn't break debugger tests

@pavelsavara
Copy link
Member Author

I tested debugger locally.

@pavelsavara pavelsavara merged commit 7f09104 into dotnet:main Dec 10, 2021
@pavelsavara pavelsavara deleted the wasm_main_js_name branch January 4, 2022 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants