Skip to content

Make ControlFlowBuilder.Clear public. #62811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

teo-tsirpanis
Copy link
Contributor

This PR makes the System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Clear() method public, as just approved. I also added a test that reuses a ControlFlowBuilder.

Fixes #58765

@ghost
Copy link

ghost commented Dec 14, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added area-System.Reflection.Metadata new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Dec 14, 2021
@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR makes the System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Clear() method public, as just approved. I also added a test that reuses a ControlFlowBuilder.

Fixes #58765

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Reflection.Metadata, new-api-needs-documentation

Milestone: -

@buyaa-n buyaa-n requested review from steveharter and tmat December 14, 2021 22:00
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@deeprobin deeprobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teo-tsirpanis teo-tsirpanis force-pushed the controlflowbuilder-clear branch from 1fdb940 to 303bdaa Compare December 15, 2021 07:18
@buyaa-n buyaa-n merged commit 6845361 into dotnet:main Dec 15, 2021
@teo-tsirpanis teo-tsirpanis deleted the controlflowbuilder-clear branch December 15, 2021 22:13
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Reset.
3 participants