Skip to content

Undo breaking change in 6.0 in environment variable configuration prefix support #62819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

maryamariyan
Copy link
Contributor

@maryamariyan maryamariyan commented Dec 14, 2021

When using environment variable configuration, brings back support for prefix being normalized like it was in dotnet 5.0.

The prefix is expected to use ":" to work (refer to updated tests).

Fixing regression from last release. Revert changes made in https://github.com/dotnet/runtime/pull/42932/files while updating tests to reduce ambiguity.

Fixes #61577

With environment variable configuration provider, undo support for normalizing prefix using double underscore
@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

When using environment variable configuration, brings back support for prefix being normalized like it was in dotnet 5.0.

The environment variable prefix should contain : if on Windows, and __ if on Linux. But the prefix is expected to use ":" to work (refer to updated tests).

Fixing regression from last release. Revert changes made in https://github.com/dotnet/runtime/pull/42932/files while updating tests to reduce ambiguity.

Fixes #61577

Author: maryamariyan
Assignees: maryamariyan
Labels:

area-Extensions-Configuration

Milestone: -

@maryamariyan maryamariyan requested a review from safern December 14, 2021 23:39
@maryamariyan maryamariyan merged commit 82866ed into dotnet:main Dec 16, 2021
@maryamariyan
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1588873597

@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in environment variable configuration prefix support in dotnet 6
2 participants