Fix _il suffix for _d/_r-variant ilproj tests #63178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs Issue DetailsOur current treatment of ilproj tests in merged wrappers is based on their naming scheme, namely the presence of the Thanks Tomas /cc @dotnet/jit-contrib
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Dec 28, 2021
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Dec 30, 2021
The tests were renamed in dotnet#63178. Fixes dotnet#63202 (and also the CI breaks in Mono leg seen in e.g. dotnet#63207).
MichalStrehovsky
added a commit
that referenced
this pull request
Dec 30, 2021
vargaz
added a commit
to vargaz/runtime
that referenced
this pull request
Jan 1, 2022
The tests were renamed in dotnet#63178.
jkotas
pushed a commit
that referenced
this pull request
Jan 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current treatment of ilproj tests in merged wrappers is based on their naming scheme, namely the presence of the
_ilsuffix in build-variant tests (tests with several ilproj scripts exercising debug vs. release and optimized vs. non-optimized build mode). For this reason I'm proposing to rename about 200 test projects to put them in sync with this naming scheme.Thanks
Tomas
/cc @dotnet/jit-contrib