Extend case optimization in MatchCharacterClass to all chars that differ by one bit #63275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
area-System.Text.RegularExpressions
tenet-performance
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIn RegexCompiler / source generator, we optimize matching a set like [Aa] to just do
|
joperezr
reviewed
Jan 3, 2022
...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
Jan 3, 2022
We have some (I know because I had a bug that caused a variety of tests to fail), but I can add some explicitly. |
stephentoub
force-pushed
the
regexmatchbit
branch
from
ecb070d to
32ab180
Compare
stephentoub
force-pushed
the
regexmatchbit
branch
from
32ab180 to
258bdad
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RegexCompiler / source generator, we optimize matching a set like [Aa] to just do
(ch | 0x20) == 'a'. But we can trivially extend this to any pair of characters that differ by only a single bit and not just to casing.