Skip to content

[release/6.0] Update COM host to match RegAsm registration behavior #63318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2022

Backport of #63292 to release/6.0

Customer Impact

Customer reported in #62529. The issue is the name of the server in the registry was the same for all managed COM servers. This changes it to match RegAsm and RegistrationServices. Presently, the same name is used for all COM servers written in managed code, "CoreCLR COMHost Server". This means that when someone is looking the Registry, they see that in the default value of the GUID key instead of the type name, as was the case using RegAsm. This has no functional change but has quality of life impact and is nice to match the existing tooling behavior in .NET Framework.

Testing

Validated the type is properly set.

Risk

Low. This is a non-functional change and is purely for COM tooling UX and other Registry probing user scenarios.

/cc @elinor-fung

@ghost ghost added the area-Host label Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #63292 to release/6.0

/cc @AaronRobinsonMSFT

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Host

Milestone: -

@AaronRobinsonMSFT AaronRobinsonMSFT added the Servicing-consider Issue for next servicing release review label Jan 3, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.x milestone Jan 3, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should take for consideration in 6.0.x

@leecow leecow added Servicing-rejected and removed Servicing-consider Issue for next servicing release review labels Jan 4, 2022
@leecow
Copy link
Member

leecow commented Jan 4, 2022

Good for .NET 7 but does not meet bar for 6.0

@AaronRobinsonMSFT AaronRobinsonMSFT deleted the backport/pr-63292-to-release/6.0 branch January 5, 2022 17:07
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants