Skip to content

Fix BigInteger outerloop test failure #64402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jan 28, 2022
Merged

Fix BigInteger outerloop test failure #64402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime.Numerics/src/System/Numerics/BigNumber.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ internal static bool TryValidateParseStyleInteger(NumberStyles style, [NotNullWh
{ // Check for hex number
if ((style & ~NumberStyles.HexNumber) != 0)
{
e = new ArgumentException(SR.Argument_InvalidHexStyle);
e = new ArgumentException(SR.Argument_InvalidHexStyle, nameof(style));
return false;
}
}
Expand Down
16 changes: 13 additions & 3 deletions src/libraries/System.Runtime.Numerics/tests/BigInteger/parse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class parseTest

// Invariant culture is commonly used for (de-)serialization and similar to en-US
// Ukrainian (Ukraine) added to catch regressions (https://github.com/dotnet/runtime/issues/14545)
// Current cultue to get additional value out of glob/loc test runs
// Current culture to get additional value out of glob/loc test runs
public static IEnumerable<object[]> Cultures
{
get
Expand Down Expand Up @@ -66,11 +66,11 @@ public static void RunParseToStringTests(CultureInfo culture)
//invalid number style
// ******InvalidNumberStyles
NumberStyles invalid = (NumberStyles)0x7c00;
AssertExtensions.Throws<ArgumentException>(null, () =>
AssertExtensions.Throws<ArgumentException>("style", () =>
{
BigInteger.Parse("1", invalid).ToString("d");
});
AssertExtensions.Throws<ArgumentException>(null, () =>
AssertExtensions.Throws<ArgumentException>("style", () =>
{
BigInteger junk;
BigInteger.TryParse("1", invalid, null, out junk);
Expand Down Expand Up @@ -116,6 +116,16 @@ public void Parse_Hex32Bits()

Assert.True(BigInteger.TryParse("080000001", NumberStyles.HexNumber, null, out result));
Assert.Equal(0x80000001u, result);

Assert.Throws<FormatException>(() =>
{
BigInteger.Parse("zzz", NumberStyles.HexNumber);
});

AssertExtensions.Throws<ArgumentException>("style", () =>
{
BigInteger.Parse("1", NumberStyles.AllowHexSpecifier | NumberStyles.AllowCurrencySymbol);
});
}

private static void RunFormatProviderParseStrings()
Expand Down