JIT: clear lvMustInit from dependent locals #64877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their initialization is handled by the parent local. CLoses dotnet#64808.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsTheir initialization is handled by the parent local. Closes #64808.
|
|
cc @dotnet/jit-contrib Cleared |
EgorBo
approved these changes
Feb 6, 2022
|
Runtime failures look like the current set of usual suspects. This change caused a handful of diffs which is a little surprising; I want to understand these better before merging. |
|
Looks like we were indeed double-initializing in some cases (eg linux, x64) ; Assembly listing for method BenchmarkDotNet.Parameters.ParameterExtractor:GetParameter(System.Collections.Generic.IEnumerable`1[ValueTuple`2],int):System.ValueTuple`2[__Canon,CompareOptions]
...
xor eax, eax
mov qword ptr [rbp-38H], rax
mov qword ptr [rbp-30H], rax
mov qword ptr [rbp-38H], rax
mov dword ptr [rbp-30H], eax |
|
Spot checked and all the diffs are like this. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their initialization is handled by the parent local.
Closes #64808.