Skip to content

[release/6.0] Improve SSL platform detection (#64923) #65054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 9, 2022

manual port of #64923 to improve TLS detection on Azure images of Server 2022.
(test only change)

  • CI matrix change: add Windows Server 2022

  • Add registry check for ssl3 - tls1.2 tests

  • Disable TLS1.3 on framework code

  • Fix typo

  • revert queue change

Co-authored-by: Jan Jahoda [email protected]

* CI matrix change: add Windows Server 2022

* Add registry check for ssl3 - tls1.2 tests

* Disable TLS1.3 on framework code

* Fix typo

* revert queue change

Co-authored-by: Jan Jahoda <[email protected]>
@wfurt wfurt added area-System.Net.Security test-enhancement Improvements of test source code labels Feb 9, 2022
@wfurt wfurt self-assigned this Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

manual port of #64923 to improve TLS detection on Azure images of Server 2022.
(test only change)

  • CI matrix change: add Windows Server 2022

  • Add registry check for ssl3 - tls1.2 tests

  • Disable TLS1.3 on framework code

  • Fix typo

  • revert queue change

Co-authored-by: Jan Jahoda [email protected]

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, test enhancement

Milestone: -

@ericstj
Copy link
Member

ericstj commented Mar 11, 2022

@wfurt is this ready to be merged? Can we get fresh PR validation results and a signoff?

@ericstj
Copy link
Member

ericstj commented Mar 11, 2022

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor

@wfurt @dotnet/ncl this is an infra change targeting release/6.0. Today is the deadline for merging servicing changes to 6.0. Can someone take a look and confirm it's good to merge and sign off? Otherwise we'll have to wait for the next servicing release.

@wfurt
Copy link
Member Author

wfurt commented Mar 11, 2022

This impacts tests. So it depends how much we care about failures. I feel this is ready but my team is probably all off already.

@carlossanlop
Copy link
Contributor

Ah my bad, I didn't notice it was test-only. I can sign it off. The CI passed successfully. I'll merge it now.

@carlossanlop carlossanlop merged commit 76a717c into dotnet:release/6.0 Mar 11, 2022
@karelz karelz added this to the 6.0.x milestone Apr 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants