Skip to content

Revert Arcade update & Workload Manifest change #71110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 22, 2022

Reverts #71046 & #68871, but keeps the SDK update to 6.0.106. Needed to unblock 6.0

@wtgodbe wtgodbe requested a review from joeloff June 22, 2022 02:32
@ghost
Copy link

ghost commented Jun 22, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned wtgodbe Jun 22, 2022
@wtgodbe wtgodbe requested review from ericstj and danmoseley June 22, 2022 02:33
@ghost
Copy link

ghost commented Jun 22, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #71046 & #68871, but keeps the SDK update to 6.0.106. Needed to unblock 6.0

Author: wtgodbe
Assignees: wtgodbe
Labels:

area-Infrastructure

Milestone: -

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 22, 2022

@danmoseley @ericstj @carlossanlop runtime will have to take an arcade update, a llvm-project update, and Jacques' change next month, plus a fix to the publish stage invoked here:

- script: >-
build.cmd -ci
-subset publish
-configuration Release
/p:PublishRidAgnosticPackagesFromPlatform=${{ parameters.PublishRidAgnosticPackagesFromPlatform }}
/p:OfficialBuildId=$(Build.BuildNumber)
/p:SignType=$(SignType)
/p:DotNetSignType=$(SignType)
/bl:$(Build.SourcesDirectory)\prepare-artifacts.binlog
displayName: Prepare artifacts and upload to build
. The problem seems to be that you're trying to upload all blobs to blobArtifacts, but there are now .msi's with duplicate names. From @joeloff:

[7:52 PM] Jacques Eloff
it organizes builds by feature band for VS insertions, so MSIs can be duplicated in multiple folders. Copying them the same location won't work.

because in staging, each sets of files for each feature band is published to a separate VSDROP container and there can be overlap, but not all blobbies have the same files.

Wanted to make sure this was on your radar. The failure happens during the AzDO artifact upload task that happens at the end of that step:

Async Command Start: Upload Artifact
...
Fail to upload 'D:\a_work\1\s\artifacts\PackageDownload\IntermediateArtifacts\workloads-vs\Insertion\6.0.300\Microsoft.AOT.win-x64.Cross.android-arm.6.0.7.msi' due to 'Blob is incomplete (missing block). Blob: af95b7c0d1f1ec11b656501ac504b8de, Expected Offset: 0, Actual Offset: 4194304'.

@carlossanlop carlossanlop requested a review from ViktorHofer June 22, 2022 03:04
@wtgodbe wtgodbe requested review from a team June 22, 2022 05:12
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 22, 2022

Could someone with perms merge this? We need it to unblock the July 6.0 build

@akoeplinger akoeplinger merged commit 705ec75 into release/6.0 Jun 22, 2022
@akoeplinger akoeplinger deleted the wtgodbe/RevertStuff branch June 22, 2022 09:50
@ericstj
Copy link
Member

ericstj commented Jun 22, 2022

@joeloff @wtgodbe can one of you please file an issue with the details around what needs to be done to absorb the arcade breaking change here? Please be more specific than what's already been shared above - like what component in arcade changed, why it changed, and how we need to react in dotnet/runtime to absorb that. If this information has already been shared then please copy it into an issue in the repo and assign the right labels. Thanks!

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 22, 2022

#71150

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 22, 2022

Just saw your request for more specificity, adding that now

@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants