JIT: hash lookup vn func before trying to optimize #72576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always consult the func hash table before trying to optimize, and record the optimized result in the hash table. Also found a few more cases where we can defer work on a VN pair when the liberal and conservative VNs match.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAlways consult the func hash table before trying to optimize, and record the Also found a few more cases where we can defer work on a VN pair when the
|
|
Another ~ -0.15% or so in TP. That plus the ~ -0.15% from #72527 should pay for #72136 (which may now be a bit cheaper as well). No diffs. @jakobbotsch PTAL |
jakobbotsch
approved these changes
Jul 21, 2022
|
Build analysis says installer failure is #70969.
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always consult the func hash table before trying to optimize, and record the
optimized result in the hash table.
Also found a few more cases where we can defer work on a VN pair when the
liberal and conservative VNs match.