-
Notifications
You must be signed in to change notification settings - Fork 5k
Move System.ValueType.s_seed into System.Runtime.CompilerServices.RuntimeHelpers #73080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
CC @tmat |
413762c
to
3b0d1f9
Compare
This still shows up as clutter in windbg/sos where DebuggerBrowsable does not kick in. For example,
It would be better to move this out of ValueType completely, e.g. to |
I can move it around if you do not have time to do it. |
@jkotas Do you mean to move just the field to RuntimeHelpers? Or the field and all the code that uses it? If the later, should I delete the method in ValueType? Or just have the method in ValueType call a method in RuntimeHelpers? |
Move the field and the one method that uses it. Update all callers to call the method in the new place. |
3b0d1f9
to
43b2e4d
Compare
DebuggerBrowsableState.Never
…timeHelpers PR dotnet#69723 added a 's_seed' field to System.ValueType. This causes the debugger to show all structs as having static members. This PR moves the field and the function that used it into RuntimeHelpers.
43b2e4d
to
5702017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PR #69723 added a 's_seed' field to System.ValueType. This causes the debugger to show all structs as having static members.
This PR moves the field and the function that used it into RuntimeHelpers.