Skip to content

[ppc64le] Bug fixes #74800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

[ppc64le] Bug fixes #74800

merged 1 commit into from
Aug 31, 2022

Conversation

alhad-deshpande
Copy link
Contributor

This PR is a manual backport for PR 74746 for release/7.0 branch. Please merge it as the original PR has already been merged in main.

@ghost ghost added area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member labels Aug 30, 2022
@alhad-deshpande
Copy link
Contributor Author

@akoeplinger
This PR is a manual backport for PR #74746 for release/7.0 branch. Please merge it as the original PR has already been merged in main.

@alhad-deshpande
Copy link
Contributor Author

/azp run runtime-community

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 74800 in repo dotnet/runtime

@stephentoub
Copy link
Member

Are we supporting ppc64le in .NET 7? I'm wondering why such fixes need to be in the release branch.

@akoeplinger
Copy link
Member

@stephentoub not from Microsoft's side, the port is maintained by IBM. This helps them carrying fewer patches.

@akoeplinger
Copy link
Member

@steveisok please approve

@carlossanlop
Copy link
Contributor

@akoeplinger can you please confirm the CI failures aren't related?

@steveisok
Copy link
Member

steveisok commented Aug 30, 2022 •
edited
Loading

The failures appear to be infra related as each one says it couldn't upload artifacts. In fact, the build analysis tab indicates they were dead lettered. I'll respin just to make sure.

@akoeplinger
Copy link
Member

This is only touching PPC64 code so it is impossible to be related to failures on ARM64 jobs. I think this is good to be merged.

@carlossanlop
Copy link
Contributor

CI failures verified as unrelated. The re-run showed cancellations/artifacts not uploaded, but no actual test failures.
Approved and signed off.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 65051a0 into dotnet:release/7.0 Aug 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alhad-deshpande @stephentoub @akoeplinger @carlossanlop @steveisok