Remove some unnecessary path manipulation helpers #77301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
jkotas
reviewed
Oct 21, 2022
| LPCWSTR ext; | ||
| size_t extSize; | ||
| SplitPathInterior(szName, NULL, 0, NULL, 0, NULL, 0, &ext, &extSize); | ||
| if (SString::_wcsicmp(ext, W(".obj")) == 0) | ||
| { | ||
| m_FileType = FILETYPE_NTOBJ; |
There was a problem hiding this comment.
We can delete this special casing of .obj and .tlb files, and the matching FILETYPE_NTOBJ and FILETYPE_TLB enums. Nothing in .NET Core should be using these. (It can be a separate PR.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @AaronRobinsonMSFT @jkotas