Skip to content

Rename COMPlus_ to DOTNET_ for IntMultipliy.csproj test #77321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Oct 21, 2022

It looks like we use DOTNET_JITMinOpts now instead of COMPlus_JITMinOpts so this should resolve: #77299

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 21, 2022
@ghost ghost assigned TIHan Oct 21, 2022
@ghost
Copy link

ghost commented Oct 21, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

It looks like we use DOTNET_JITMinOpts now instead of COMPlus_JITMinOpts so this should resolve: #77299

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Oct 21, 2022

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

<CLRTestEnvironmentVariable Include="COMPlus_TieredCompilation" Value="0" />
<CLRTestEnvironmentVariable Include="COMPlus_JITMinOpts" Value="0" />
<CLRTestEnvironmentVariable Include="DOTNET_TieredCompilation" Value="0" />
<CLRTestEnvironmentVariable Include="DOTNET_JITMinOpts" Value="0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these needed? it seems to be default for tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since it will force JTMinOpts to always be 0 even when the test CI leg sets JITMinOpts to 1. We haven't done enough work to try to exclude certain tests based on the environment variables they rely on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a little odd to me, COMPlus_ is an accepted prefix to the environment variables, so why doesn't the old alias work to force min-opts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are two of the same env variables at play? What happens if "DOTNET_JitMinOpts=1" and "COMPlus_JItMinOpts=0" are set at the same time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, so the problem is happening due to both of them being set to different values. That makes sense.

@TIHan TIHan merged commit 77331bb into dotnet:main Oct 21, 2022
@TIHan TIHan deleted the ci-fix-1 branch October 21, 2022 21:59
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure JIT/opt/Multiply/IntMultiply/IntMultiply.sh
4 participants