-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Rename COMPlus_ to DOTNET_ for IntMultipliy.csproj test #77321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt looks like we use
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 2 pipeline(s). |
<CLRTestEnvironmentVariable Include="COMPlus_TieredCompilation" Value="0" /> | ||
<CLRTestEnvironmentVariable Include="COMPlus_JITMinOpts" Value="0" /> | ||
<CLRTestEnvironmentVariable Include="DOTNET_TieredCompilation" Value="0" /> | ||
<CLRTestEnvironmentVariable Include="DOTNET_JITMinOpts" Value="0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these needed? it seems to be default for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since it will force JTMinOpts to always be 0
even when the test CI leg sets JITMinOpts to 1
. We haven't done enough work to try to exclude certain tests based on the environment variables they rely on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still a little odd to me, COMPlus_
is an accepted prefix to the environment variables, so why doesn't the old alias work to force min-opts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there are two of the same env variables at play? What happens if "DOTNET_JitMinOpts=1" and "COMPlus_JItMinOpts=0" are set at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, so the problem is happening due to both of them being set to different values. That makes sense.
It looks like we use
DOTNET_JITMinOpts
now instead ofCOMPlus_JITMinOpts
so this should resolve: #77299