[PERF][Release/7.0] Update release/7.0 Perf infrastructure to use Perf repo release/7.0 branch #77699
Conversation
) * Adds passing of locally obtained git commit time to ci_setup allowing for the bypassing of calling the github.com api. * Added use local commit time to run-scenarios yml. * Fixed uselocalcommittime format for linux setup. * Use correct quote style for passing time to ci_setup.py.
ghost
added
the
|
Perf run wasm stuff is failing due to #76939 |
…installed from channel 6.0.4xx to 6.0.
|
@carlossanlop or @hoyosjs Is this able to get merged in? This only makes changes affecting the performance testing infrastructure, which is generally succeeding on par with main based on this test https://dev.azure.com/dnceng/internal/_build/results?buildId=2035459&view=results. |
| @@ -323,7 +334,7 @@ else | |||
| if [[ -n "$perf_fork" ]]; then | |||
| git clone --branch $perf_fork_branch --depth 1 --quiet $perf_fork $performance_directory | |||
| else | |||
| git clone --branch main --depth 1 --quiet https://github.com/dotnet/performance.git $performance_directory | |||
| git clone --branch release/7.0 --depth 1 --quiet https://github.com/dotnet/performance.git $performance_directory | |||
There was a problem hiding this comment.
Just as a future thing, do you think it's worth using the build agent variables here?
There was a problem hiding this comment.
Where do the build agent variables get set/added from? I like the idea, and it may be worth making something in this area that will use the variable if it is properly available. At the very least, it is worthwhile to look into it.
There was a problem hiding this comment.
If there is a good Doc link to make sure I am thinking of the correct thing when you say build agent variable would be great.
There was a problem hiding this comment.
See https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml, particularly something like Build.SourceBranchName if this doesn't run on PRs, and use System.PullRequest.TargetBranch for PRs, that way you don't have to patch when branching.
|
This is ready to be merged. |
|
Seems the installer OSX leg died abruptly and got stuck: https://dev.azure.com/dnceng-public/public/_build/results?buildId=70816&view=logs&j=7f86d1c0-3940-52e8-addc-832174c2a54b&t=70c2ada8-6d01-57b0-3635-3ffb5eecdc77 The other CI failure is a regular expressions test timeout, I opened an issue for it: #77814 Merging now since Juan approved it. |
This updates the performance branch that release/7.0 runs will use going forward so main changes don't break testing here. This includes the branch specifier change and some fixes and parity changes to more closely match mains infrastructure at the moment.