Skip to content

[Android] Add error code to the assert error message #80423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonrozsival
Copy link
Member

There is a report of a crash when JNI AttachCurrentThreadAsDaemon method is called (#79395). The logs don't contain any relevant information so it's hard to diagnose the root of the problem. We should output the error code returned from AttachCurrentThreadAsDaemon to make diagnosing the error easier.

@ghost
Copy link

ghost commented Jan 10, 2023

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

There is a report of a crash when JNI AttachCurrentThreadAsDaemon method is called (#79395). The logs don't contain any relevant information so it's hard to diagnose the root of the problem. We should output the error code returned from AttachCurrentThreadAsDaemon to make diagnosing the error easier.

Author: simonrozsival
Assignees: -
Labels:

area-System.Net.Security, os-android

Milestone: -

@simonrozsival
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival simonrozsival merged commit 4cf8c07 into dotnet:main Jan 16, 2023
@simonrozsival simonrozsival deleted the jni-unable-to-attach-thread-crash branch January 16, 2023 15:50
@simonrozsival

This comment was marked as duplicate.

@simonrozsival
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3931955733

@simonrozsival
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3932028555

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants