[main] Update dependencies from 9 repositories #80429

…30109.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.23052.2 -> To Version 1.0.0-prerelease.23059.1

…ld 20230109.2 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.23059.1 -> To Version 8.0.0-beta.23059.2

…uild 20230109.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.3.4-beta1.23058.2 -> To Version 3.3.4-beta1.23059.1

…ild 20230109.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.22628.1 -> To Version 1.1.0-alpha.0.23059.1

ViktorHofer · 2023-01-11T10:44:22Z

.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/1.1.0-alpha.0.23059.1/build/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.targets(28,5): error MSB4062: (NETCORE_ENGINEERING_TELEMETRY=Build) The "HotReloadDeltaGeneratorComputeScriptOutputs" task could not be loaded from the assembly /__w/1/s/.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/1.1.0-alpha.0.23059.1/build/../tools/net7.0/Microsoft.DotNet.HotReload.Utils.Generator.Tasks.dll. Could not load file or assembly '/__w/1/s/.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/1.1.0-alpha.0.23059.1/tools/net7.0/Microsoft.DotNet.HotReload.Utils.Generator.Tasks.dll'. The system cannot find the file specified.
Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

Regressed with dotnet/hotreload-utils#229 and will be fixed with dotnet/hotreload-utils#230

ViktorHofer · 2023-01-11T16:01:05Z

This is now blocked by #80234 as hotreload-utils already is on an 8.0 SDK.

janvorli · 2023-01-12T18:09:23Z

The crossgen2 (I've tested the Linux x64 leg) fails with stack overflow at about 75000 frames. It happens down the call chain of the S_P_CoreLib_System_AppContext__SetData, so well before the crossgen2 code is executed.
You can see bottom 36000 frames of the stack trace in the gist at https://gist.github.com/janvorli/8ce94e65ac17bba484defeac46e8c418.

To repro this, I've checked out this PR's change and ran:
./build.sh -arch x64 -os linux -c debug -runtimeConfiguration release /p:CrossBuild=false /p:MonoLLVMUseCxx11Abi=false

When it failed, I've just copied the command the error message logged and ran it under lldb. In my case, it was:
lldb -- /home/janvorli/git/runtime4/artifacts/bin/coreclr/linux.x64.Debug/crossgen2/linux-x64/publish/crossgen2 /home/janvorli/git/runtime4/artifacts/bin/coreclr/linux.x64.Release/IL/System.Private.CoreLib.dll --out /home/janvorli/git/runtime4/artifacts/obj/Microsoft.NETCore.App.Crossgen2/Debug/net8.0/linux-x64/S.P.C.tmp

ViktorHofer · 2023-01-12T18:23:14Z

The crossgen2 (I've tested the Linux x64 leg) fails with stack overflow at about 75000 frame

@MichalStrehovsky can you please take a look? cc @vitek-karas

MichalStrehovsky · 2023-01-13T02:51:11Z

The crossgen2 (I've tested the Linux x64 leg) fails with stack overflow at about 75000 frame

So Roslyn is now generating reflection calls in places that have nothing to do with reflection and since NativeAOT implements reflection in C#, we get reflection in the middle of reflection implementation, which calls reflection,.... you get the picture.

The method body for this:

runtime/src/coreclr/nativeaot/Common/src/System/Collections/Concurrent/ConcurrentUnifierW.cs

Lines 179 to 200 in f97f5be

    
           public bool TryGetValue(K key, int hashCode, out V? value) 
        
           { 
        
               // Lock acquistion NOT required. 
        
               int bucket = ComputeBucket(hashCode, _buckets.Length); 
        
               int i = Volatile.Read(ref _buckets[bucket]); 
        
               while (i != -1) 
        
               { 
        
                   if (key.Equals(_entries[i]._key)) 
        
                   { 
        
                       // We found the entry for the key but the weak reference may have expired. If it did expire, do NOT 
        
                       // try to refill it here. To maintain the appearance of value immortality, ONLY the entry belonging 
        
                       // to the most up to date chain can be refilled in this way and we can only be sure of doing that we're 
        
                       // inside the lock. 
        
                       return _entries[i]._weakValue.TryGetTarget(out value); 
        
                   } 
        
                   i = _entries[i]._next; 
        
               } 
        
               value = default(V); 
        
               return false; 
        
           }

Now has an implicit typeof(K).IsValueType call generated around the key.Equals

I think this was introduced in dotnet/roslyn#66311? Cc @AlekseyTs @jkotas

jkotas · 2023-01-13T02:57:28Z

@AlekseyTs I think we should revert the change in Roslyn so that we understand the impact and the best way forward without time pressure and blocking code flow.

MichalStrehovsky · 2023-01-13T02:57:46Z

We could fix this by making IsValueType a mustExpand intrinsic in the JIT (maybe?). But not all codegens expand this. I don't know how much the IsValueType call regresses perf for Mono for example. I don't particularly like seeing Roslyn generate calls into reflection APIs behind user's back.

jkotas · 2023-01-13T03:00:36Z

I don't know how much the IsValueType call regresses perf for Mono for example.

I assume that this codegen changed for all runtimes. It means that this would also regress performance significantly for older .NET Core versions and .NET Framework where Type.IsValueType is not treated as intrinsic.

ViktorHofer · 2023-01-13T08:20:40Z

Thanks for talking a look Michal!

Roslyn dependency updates already have been painful enough to make me switch the subscription to non batchable, to not prelong other updates and being able to invastigate Roslyn changes separately.

EDIT: I just removed the roslyn dependency updates from the PR.

…11.1 Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100 From Version 8.0.0-alpha.1.23054.1 -> To Version 8.0.0-alpha.1.23061.1

…10.1 Microsoft.DotNet.Cecil , Microsoft.DotNet.Cecil.Pdb From Version 0.11.4-alpha.23053.1 -> To Version 0.11.4-alpha.23060.1

…ild 20230111.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.22628.1 -> To Version 1.1.0-alpha.0.23061.2

… 20230111.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 14.0.0-alpha.1.22626.2 -> To Version 14.0.0-alpha.1.23061.1

…otnet-optimization build 20230111.7 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.22511.6 -> To Version 1.0.0-prerelease.23061.7

AlekseyTs · 2023-01-13T14:44:52Z

I think we should revert the change in Roslyn so that we understand the impact and the best way forward without time pressure and blocking code flow.

Created a revert PR, dotnet/roslyn#66407

…l." (#66407) Reverts #66311 due to dotnet/runtime#80429 (comment)

Update dependencies from https://github.com/dotnet/icu build 20230109.1

35533af

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-alpha.1.23056.1 -> To Version 8.0.0-alpha.1.23059.1

ghost added the area-codeflow for labeling automated codeflow label Jan 10, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/icu~~ [main] Update dependencies from dotnet/icu dotnet/xharness Jan 10, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/icu dotnet/xharness~~ [main] Update dependencies from dotnet/icu dotnet/xharness dotnet/runtime-assets Jan 10, 2023

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

754afa4

…uild 20230109.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.3.4-beta1.23058.2 -> To Version 3.3.4-beta1.23059.1

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/icu dotnet/xharness dotnet/runtime-assets~~ [main] Update dependencies from dotnet/icu dotnet/xharness dotnet/runtime-assets dotnet/roslyn-analyzers Jan 10, 2023

Update dependencies from https://github.com/dotnet/hotreload-utils bu…

0ec6112

…ild 20230109.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.22628.1 -> To Version 1.1.0-alpha.0.23059.1

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/icu dotnet/xharness dotnet/runtime-assets dotnet/roslyn-analyzers~~ [main] Update dependencies from dotnet/icu dotnet/xharness dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/hotreload-utils Jan 10, 2023

This was referenced Jan 10, 2023

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Tracking issue for CI build failure "Installing openssl@3 has failed!" #80428

Closed

Tracking issue for CI build timeouts #76454

Closed

ViktorHofer closed this Jan 11, 2023

ViktorHofer reopened this Jan 11, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/roslyn-analyzers dotnet/hotreload-utils dotnet/roslyn dotnet/icu dotnet/xharness dotnet/runtime-assets~~ [main] Update dependencies from 7 repositories Jan 11, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from 7 repositories~~ [main] Update dependencies from 8 repositories Jan 11, 2023

ViktorHofer approved these changes Jan 11, 2023

View reviewed changes

ViktorHofer added the blocked Issue/PR is blocked on something - see comments label Jan 11, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from 8 repositories~~ [main] Update dependencies from 9 repositories Jan 11, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from 9 repositories~~ [main] Update dependencies from 10 repositories Jan 12, 2023

ViktorHofer closed this Jan 12, 2023

ViktorHofer removed the blocked Issue/PR is blocked on something - see comments label Jan 12, 2023

ViktorHofer reopened this Jan 12, 2023

ViktorHofer closed this Jan 12, 2023

ViktorHofer reopened this Jan 12, 2023

tlakollo mentioned this pull request Jan 13, 2023

Update manually the cecil version #80592

Closed

dotnet-maestro bot added 5 commits January 13, 2023 09:29

Update dependencies from https://github.com/dotnet/emsdk build 202301…

c5c91e7

…11.1 Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100 From Version 8.0.0-alpha.1.23054.1 -> To Version 8.0.0-alpha.1.23061.1

Update dependencies from https://github.com/dotnet/cecil build 202301…

7d827cd

…10.1 Microsoft.DotNet.Cecil , Microsoft.DotNet.Cecil.Pdb From Version 0.11.4-alpha.23053.1 -> To Version 0.11.4-alpha.23060.1

Update dependencies from https://github.com/dotnet/hotreload-utils bu…

5774783

…ild 20230111.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.22628.1 -> To Version 1.1.0-alpha.0.23061.2

ViktorHofer force-pushed the darc-main-71fcb20a-c62e-4e89-a243-64c2272f599e branch from 943a895 to 0d78706 Compare January 13, 2023 08:29

ViktorHofer changed the title ~~[main] Update dependencies from 10 repositories~~ [main] Update dependencies from 9 repositories Jan 13, 2023

ViktorHofer merged commit e524623 into main Jan 13, 2023

ViktorHofer deleted the darc-main-71fcb20a-c62e-4e89-a243-64c2272f599e branch January 13, 2023 11:01

This was referenced Jan 13, 2023

Revert "Do not copy nullable value type receiver of a constrained call." dotnet/roslyn#66407

Merged

Nullable value type receiver of a constrained call is unexpectedly copied dotnet/roslyn#66162

Closed

AlekseyTs added a commit to dotnet/roslyn that referenced this pull request Jan 13, 2023

Revert "Do not copy nullable value type receiver of a constrained cal…

1dd4753

…l." (#66407) Reverts #66311 due to dotnet/runtime#80429 (comment)

ghost locked as resolved and limited conversation to collaborators Feb 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[main] Update dependencies from 9 repositories #80429

[main] Update dependencies from 9 repositories #80429

Uh oh!

dotnet-maestro bot commented Jan 10, 2023 •

edited

Loading

Uh oh!

ViktorHofer commented Jan 11, 2023

Uh oh!

ViktorHofer commented Jan 11, 2023

Uh oh!

janvorli commented Jan 12, 2023

Uh oh!

ViktorHofer commented Jan 12, 2023

Uh oh!

MichalStrehovsky commented Jan 13, 2023

Uh oh!

jkotas commented Jan 13, 2023 •

edited

Loading

Uh oh!

MichalStrehovsky commented Jan 13, 2023

Uh oh!

jkotas commented Jan 13, 2023

Uh oh!

ViktorHofer commented Jan 13, 2023 •

edited

Loading

Uh oh!

AlekseyTs commented Jan 13, 2023

Uh oh!

Uh oh!

[main] Update dependencies from 9 repositories #80429

[main] Update dependencies from 9 repositories #80429

Uh oh!

Conversation

dotnet-maestro bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/icu

From https://github.com/dotnet/xharness

From https://github.com/dotnet/runtime-assets

From https://github.com/dotnet/roslyn-analyzers

From https://github.com/dotnet/hotreload-utils

From https://github.com/dotnet/roslyn

From https://github.com/dotnet/emsdk

From https://github.com/dotnet/cecil

From https://github.com/dotnet/llvm-project

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

Uh oh!

ViktorHofer commented Jan 11, 2023

Uh oh!

ViktorHofer commented Jan 11, 2023

Uh oh!

janvorli commented Jan 12, 2023

Uh oh!

ViktorHofer commented Jan 12, 2023

Uh oh!

MichalStrehovsky commented Jan 13, 2023

Uh oh!

jkotas commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalStrehovsky commented Jan 13, 2023

Uh oh!

jkotas commented Jan 13, 2023

Uh oh!

ViktorHofer commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlekseyTs commented Jan 13, 2023

Uh oh!

Uh oh!

dotnet-maestro bot commented Jan 10, 2023 •

edited

Loading

jkotas commented Jan 13, 2023 •

edited

Loading

ViktorHofer commented Jan 13, 2023 •

edited

Loading