Skip to content

[mono][tests] Enable dynamic linking for maccatalyst in sandbox environment #88847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 1 commit into from
Jul 14, 2023
Merged

[mono][tests] Enable dynamic linking for maccatalyst in sandbox environment #88847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mono/sample/iOS/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ run-sim: clean appbuilder
/p:TargetOS=iossimulator \
/p:TargetArchitecture=$(MONO_ARCH) \
/p:MonoEnableLLVM=$(USE_LLVM) \
/p:MonoForceInterpreter=false \
/p:DeployAndRun=$(DEPLOY_AND_RUN) \
/p:RuntimeComponents="$(RUNTIME_COMPONENTS)" \
/p:DiagnosticPorts="$(DIAGNOSTIC_PORTS)" \
Expand All @@ -76,6 +77,7 @@ run-catalyst: clean appbuilder
/p:TargetOS=maccatalyst \
/p:TargetArchitecture=$(MONO_ARCH) \
/p:MonoEnableLLVM=false \
/p:MonoForceInterpreter=false \
/p:DeployAndRun=$(DEPLOY_AND_RUN) \
/p:EnableAppSandbox=$(APP_SANDBOX) \
/bl
Expand All @@ -85,7 +87,7 @@ run-catalyst-interp: clean appbuilder
-c $(MONO_CONFIG) \
/p:TargetOS=maccatalyst \
/p:TargetArchitecture=$(MONO_ARCH) \
/p:MonoEnableLLVM=False \
/p:MonoEnableLLVM=false \
/p:MonoForceInterpreter=true \
/p:DeployAndRun=$(DEPLOY_AND_RUN) \
/p:EnableAppSandbox=$(APP_SANDBOX) \
Expand Down
2 changes: 1 addition & 1 deletion src/tasks/AppleAppBuilder/AppleAppBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public void ValidateRuntimeSelection()

public override bool Execute()
{
bool shouldStaticLink = true;
bool shouldStaticLink = !EnableAppSandbox;
bool isDevice = (TargetOS == TargetNames.iOS || TargetOS == TargetNames.tvOS);

ValidateRuntimeSelection();
Expand Down