Skip to content

[wasm] Move code around in WBT in preparation for fixes, and cleanups #88980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 15 commits into from
Jul 17, 2023
Merged

[wasm] Move code around in WBT in preparation for fixes, and cleanups #88980

radical merged 15 commits into from
Jul 17, 2023

Conversation

@radical
Copy link
Member

@radical radical commented Jul 17, 2023 •
edited
Loading

  • WBT: Move some common methods to TestUtils.cs
  • WBT: Add new project type specific base classes for the tests
  • WBT: Move blazor specific code from BuildTestBase into
  • WBT: Move more code from BuildTestBase to the respective provider, and test classes

This PR is mainly moving code around, and not fixing, cleaning, or rationalizing code.

A follow up PR will start merging common code, fixing testing bundles, icu etc.

radical added 3 commits July 17, 2023 00:47
@radical
WBT: Move some common methods to TestUtils.cs
8c4e4bc
@radical
WBT: Add new project type specific base classes for the tests
62aa7aa 
.. derived from `BuildTestBase.
@radical
WBT: Move blazor specific code from BuildTestBase into
9fe66d2 
.. BlazorWasmProjectProvider, and BlazorWasmTestBase. This commit avoids
doing any cleanup, and just moves code around.
@radical radical added the arch-wasm WebAssembly architecture label Jul 17, 2023
@ghost ghost added the area-Build-mono label Jul 17, 2023
@ghost ghost assigned radical Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • WBT: Move some common methods to TestUtils.cs
  • WBT: Add new project type specific base classes for the tests
  • WBT: Move blazor specific code from BuildTestBase into
  • WBT: Move more code from BuildTestBase to the respective provider, and test classes
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical force-pushed the wbt-follow-pr-first branch from bd9e372 to a6fb183 Compare July 17, 2023 05:30
@radical radical requested review from maraf and pavelsavara July 17, 2023 05:31
@radical radical requested a review from lewing July 17, 2023 06:50
@radical
Copy link
Member Author

radical commented Jul 17, 2023

I would suggest reviewing this commit-wise.

@radical radical mentioned this pull request Jul 17, 2023
Closed
@radical radical changed the title [wasm] Move code around in WBT in preparation for fixes, and cleanups" [wasm] Move code around in WBT in preparation for fixes, and cleanups Jul 17, 2023
@radical radical marked this pull request as ready for review July 17, 2023 08:49
@radical
Copy link
Member Author

radical commented Jul 17, 2023

Missed updating the list of tests. I'll open a separate PR after these refactoring ones to generate the list at build time.

@radical radical mentioned this pull request Jul 17, 2023
Closed
maraf
maraf approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@radical radical merged commit 6e65f51 into dotnet:main Jul 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@lewing lewing Awaiting requested review from lewing

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @maraf