-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Move full facade assemblies into src/libraries/shims #89184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
261c760
5e746ce
8c20c81
bf300ac
08f1468
912e897
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,6 @@ | |
| <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <DefaultReferenceExclusion Include="System.Diagnostics.Debug" /> | ||
| <DefaultReferenceExclusion Include="System.Runtime.Extensions" /> | ||
| <DefaultReferenceExclusion Include="System.Collections" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the reason for these and the change? Is it just to avoid duplicate types?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct. The default reference exclusion was necessary when these assemblies still contained types and weren't pure facade assemblies because of duplicate types. |
||
| <ProjectReference Include="$(CoreLibProject)" /> | ||
| <ProjectReference Include="$(LibrariesProjectRoot)System.Runtime\src\System.Runtime.csproj" /> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.