Cleanup work #89976
Cleanup work #89976
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsMiscellaneous cleanup work: Implementing
|
| @@ -249,7 +249,7 @@ extends: | |||
| extraStepsTemplate: /eng/pipelines/coreclr/nativeaot-post-build-steps.yml | |||
| extraStepsParameters: | |||
| creator: dotnet-bot | |||
| testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;tracing/eventpipe/config;tracing/eventpipe/diagnosticport;tracing/eventpipe/reverse;tracing/eventpipe/processenvironment;tracing/eventpipe/simpleruntimeeventvalidation;tracing/eventpipe/processinfo2;" test tracing/eventcounter/runtimecounters.csproj /p:BuildNativeAotFrameworkObjects=true' | |||
| testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;tracing;" /p:BuildNativeAotFrameworkObjects=true' | |||
There was a problem hiding this comment.
I recall we hit issues with PR legs timing out when all tracing tests were added to the build. Won't that be a problem again?
There was a problem hiding this comment.
The build seems faster now with around 50 mins or so. I would like to get fuller test coverage and can reduce the set if this becomes a problem again.
There was a problem hiding this comment.
Okay - as long as you're aware / watching out for it. I thought 50 min test build was about what it was when we were timeouts (in combination with the time for running in helix), but may be misremembering.
There was a problem hiding this comment.
Increased the timeout to 180 minutes in line with some of the long running CI steps.
Co-authored-by: Elinor Fung <[email protected]>
…into EventPipeCleanup
|
Closing and re-opening to pick up #90118. |
ghost
locked as resolved and limited conversation to collaborators
Miscellaneous cleanup work: Implements
ep_rt_aot_thread_has_started,RhEventPipeInternal_EventActivityIdControlthat allows per-thread activity ID, generating a valid thread handle forstreaming_threadinEventPipe(EventPipecallsep_rt_aot_thread_has_startedwhich will cause issues unless its a valid thread handle now), not handling events related to GCHeapDumpKeyword and TypeKeyword (until issue #88491 is fixed correctly), and expanding testing.