DCS work nicely with collectible AssemblyLoadContext #90437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
reviewed
Aug 11, 2023
...es/System.Private.DataContractSerialization/src/System/Runtime/Serialization/ContextAware.cs
Show resolved
Hide resolved
mconnew
reviewed
Aug 11, 2023
| } | ||
|
|
||
| public DataContract? GetItem(int index) => _contracts[index].strong ?? (_contracts[index].weak?.TryGetTarget(out DataContract? ret) == true ? ret : null); | ||
|
|
There was a problem hiding this comment.
It's only a style thing, but did you consider having providing an indexer property instead of switching to Get and Set methods?
There was a problem hiding this comment.
Sort of an evolution of the context-aware side of the design that got away from the original usage pattern. An indexer would fit the original code. But the nullable notation of the original code was incorrect, even if our code was dilligent about null-checking. Maybe I've still got Monday brain, but I don't know of a way to make the getter nullable and the setter non-nullable... notation-wise anyway.
mconnew
reviewed
Aug 12, 2023
...es/System.Private.DataContractSerialization/src/System/Runtime/Serialization/ContextAware.cs
Show resolved
Hide resolved
|
The only change that needs to happen is move the second check inside of the locks then this is good to merge. |
3 tasks
mconnew
approved these changes
Aug 14, 2023
…unning the 'create' delegate. Docs suggest this is intentional and will remain the case.
mconnew
approved these changes
Aug 14, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the draft PR (#88791) that I was using earlier. The pre-requisite changes that were staged in the first few commits of that draft got checked in under their own PR with proper contributor attribution (#73893), so this PR cherry-picks the rest of that draft and then addresses the feedback.
Fixes #77877