[release/8.0-staging] Support IValidatableObject for nested model types in options source gen #94062
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
needs-area-label
tarekgh
added
area-Extensions-Options
source-generator
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsBackport of #93952 to release/8.0-staging /cc @tarekgh Customer ImpactCustomers who employ nested options objects and rely on the TestingThe changes have successfully passed all regression tests, and we have additionally introduced new tests that cover the specific scenario affected by these changes. RiskThis fix is narrowly scoped to a one-line change, targeting only the scenario that was failing. IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@ericstj @carlossanlop could you please help review the package authoring part? |
| @@ -4,6 +4,8 @@ | |||
| <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.1;netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks> | |||
| <EnableDefaultItems>true</EnableDefaultItems> | |||
| <IsPackable>true</IsPackable> | |||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | |||
| <ServicingVersion>1</ServicingVersion> | |||
There was a problem hiding this comment.
Congrats @tarekgh, you're the first one to service an 8.0 package :)
tarekgh
added
Servicing-approved
|
This is approved offline by email. |
Backport of #93952 to release/8.0-staging
/cc @tarekgh
Customer Impact
Customers who employ nested options objects and rely on the
IValidateObjectinterface may notice that nested object validation is skipped when using the source generator. This omission can lead to unexpected behavior in the affected application. This issue has been reported by a partner team.Testing
The changes have successfully passed all regression tests, and we have additionally introduced new tests that cover the specific scenario affected by these changes.
Risk
This fix is narrowly scoped to a one-line change, targeting only the scenario that was failing.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.