Skip to content

[browser][fix] maxParallelDownloads #95793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

[browser][fix] maxParallelDownloads #95793

merged 1 commit into from
Dec 11, 2023

Conversation

pavelsavara
Copy link
Member

Fixes #95491

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 8, 2023
@pavelsavara pavelsavara added this to the 8.0.x milestone Dec 8, 2023
@pavelsavara pavelsavara self-assigned this Dec 8, 2023
@ghost
Copy link

ghost commented Dec 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #95491

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 8.0.x

@pavelsavara
Copy link
Member Author

Here I tested both retry and throttling

image

@pavelsavara pavelsavara marked this pull request as ready for review December 8, 2023 16:35
@pavelsavara pavelsavara requested review from kg and lewing as code owners December 8, 2023 16:35
@pavelsavara pavelsavara requested a review from maraf December 8, 2023 16:35
This was referenced Dec 8, 2023
Open
Closed
maraf
maraf reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should have an automated test. I'll add one to the testappscenarios

@pavelsavara pavelsavara merged commit 1b8fbab into dotnet:main Dec 11, 2023
@pavelsavara pavelsavara deleted the browser_fix_maxParallelDownloads branch December 11, 2023 16:54
@lewing
Copy link
Member

lewing commented Dec 11, 2023

/backport to release/8.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7171372749

@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Merged
@pavelsavara
Copy link
Member Author

@MackinnonBuck it would be good if you could test this once it arrives into blazor, ideally before we merge the backport.

@MackinnonBuck MackinnonBuck mentioned this pull request Jan 10, 2024
Merged
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@akoeplinger akoeplinger modified the milestones: 8.0.x, 8.0.2 Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf left review comments

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] Setting maxParallelDownloads sometimes has no effect

5 participants

@pavelsavara @lewing @maraf @MackinnonBuck @akoeplinger