Move various thread-local objects that were used in self-contained places out of Thread #99989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l of StackingAllocatorHolder instead of Thread
…tRandomInt's implementation (no reliance on the Thread object)
|
Tagging subscribers to this area: @mangod9 |
|
Does it address #99661 too? |
|
It doesn't currently (as that's used a little more often than the metric I used), but I can try making it so. |
jkotas
reviewed
Mar 20, 2024
jkotas
reviewed
Mar 20, 2024
jkotas
reviewed
Mar 20, 2024
jkotas
reviewed
Mar 20, 2024
This should be done in a separate change. It will chance a lot of places like assembly helpers. |
…y one place that will use it in release builds, and it will only be used once in the process (all other uses are debug-only)
|
/ba-g The unrecognized failure is #99142, which was closed as a fix was made after this PR started running CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the following type's thread-specific trackers out of the
Threadobject and into self-contained fields/thread_local globals:Each of these were only used in one centralized location and the only usage of the
Threadobject was to fetch the object for the given thread. I've validated that for each of these cases, MSVC makes the same inlining decisions it made before this PR.Also, remove the thread-specific RCW active list as that code is never used.