Skip to content

Added codes to messages #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Added codes to messages #357

merged 2 commits into from
Mar 6, 2023

Conversation

MichalPavlik
Copy link
Member

@MichalPavlik MichalPavlik commented Feb 23, 2023

Fixes #329

CONTAINER1xxx: HTTP or local daemon related failures
CONTAINER2xxx: Invalid/missing data related failures
CONTAINER3xxx: Docker process related failures

@MichalPavlik MichalPavlik requested a review from a team February 23, 2023 15:21
@vlada-shubina
Copy link
Member

Just to double check, are logged errors,

Log.LogError($"Couldn't find matching base image for {0} that matches RuntimeIdentifier {1}", sourceImageReference.RepositoryAndTag, ContainerRuntimeIdentifier);
for example, to be done in separate PR?

@MichalPavlik
Copy link
Member Author

Just to double check, are logged errors,

Log.LogError($"Couldn't find matching base image for {0} that matches RuntimeIdentifier {1}", sourceImageReference.RepositoryAndTag, ContainerRuntimeIdentifier);

for example, to be done in separate PR?

I would do it in separate PR.

@baronfel
Copy link
Member

I made an issue for the remaining work

@baronfel
Copy link
Member

@MichalPavlik were you able to check that these show nicely in VS when they are triggered?

@@ -223,7 +223,7 @@ internal class Strings {
}

/// <summary>
/// Looks up a localized string similar to Unrecognized mediaType &apos;{0}&apos;..
/// Looks up a localized string similar to CONTAINER2001: Unrecognized mediaType &apos;{0}&apos;..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this PR but why are we using the old designer generation here, rather than the MSBuild-integrated one that works everywhere and doesn't require this stuff to be checked in?

Copy link
Member Author

@MichalPavlik MichalPavlik Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean GenerateResource task? Good question. Does it generate also properties matching resource names? I have to take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can (but it's a bit of a pain to turn it all on today: dotnet/msbuild#4751).

@baronfel
Copy link
Member

baronfel commented Mar 6, 2023

We're going to merge this even though the messages don't show the way we want in VS's error pane. This still gives us a good foundation to build on in terms of resources and error codes, and we'll log any further work necessary after consult with @vijayrkn and @anvillan.

@baronfel baronfel merged commit 0b5b28c into main Mar 6, 2023
@baronfel baronfel deleted the error-codes branch March 6, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use codes for errors and warnings
4 participants