-
Notifications
You must be signed in to change notification settings - Fork 41
Added codes to messages #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just to double check, are logged errors,
|
I would do it in separate PR. |
I made an issue for the remaining work |
@MichalPavlik were you able to check that these show nicely in VS when they are triggered? |
@@ -223,7 +223,7 @@ internal class Strings { | |||
} | |||
|
|||
/// <summary> | |||
/// Looks up a localized string similar to Unrecognized mediaType '{0}'.. | |||
/// Looks up a localized string similar to CONTAINER2001: Unrecognized mediaType '{0}'.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR but why are we using the old designer generation here, rather than the MSBuild-integrated one that works everywhere and doesn't require this stuff to be checked in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean GenerateResource task? Good question. Does it generate also properties matching resource names? I have to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can (but it's a bit of a pain to turn it all on today: dotnet/msbuild#4751).
Fixes #329
CONTAINER1xxx: HTTP or local daemon related failures
CONTAINER2xxx: Invalid/missing data related failures
CONTAINER3xxx: Docker process related failures