Skip to content

Add workload force clean option #19603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #30008
sfoslund opened this issue Aug 9, 2021 · 5 comments · Fixed by #30266
Closed
Tracked by #30008

Add workload force clean option #19603

sfoslund opened this issue Aug 9, 2021 · 5 comments · Fixed by #30266
Assignees
Labels
Area-Workloads Cost:S Less than 4 person weeks of work per central guidance Priority:1 Work that is critical for the release, but we could probably ship without User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@sfoslund
Copy link
Member

sfoslund commented Aug 9, 2021

Consider adding an option to remove all old workload/pack installation records. Users can run into issues and want this functionality during previews where a workload is renamed and as a result cannot be uninstalled due to being unrecognized by the resolver.

@ghost ghost added Area-Workloads untriaged Request triage from a team member labels Aug 9, 2021
@sfoslund sfoslund removed the untriaged Request triage from a team member label Aug 9, 2021
@sfoslund sfoslund added this to the 6.0.1xx milestone Aug 9, 2021
@sfoslund
Copy link
Member Author

@marcpopMSFT did you assign this to me because we decided we want this change or was this assigned for triage?

@marcpopMSFT
Copy link
Member

@Redth Will mentioned that ya'll might be adding a clean option to maui check that would help here. We've seen a lot of preview to preview upgrade issues and this was one option we thought of to help with that but a maui check clean might help as well.

@Redth
Copy link
Member

Redth commented Aug 19, 2021

@marcpopMSFT i haven't gotten around to it yet, but I did create a .ps1 script to do this. It might be better this way so users can tell what it's going to do / doing instead of a more ambiguous clean option on Maui-check itself.

https://github.com/Redth/dotnet-maui-check/blob/main/Clean-Old-DotNet6-Previews.ps1

@marcpopMSFT marcpopMSFT modified the milestones: 6.0.1xx, 6.0.2xx Oct 6, 2021
@marcpopMSFT
Copy link
Member

Options for clean:

  • Rollback to baseline manifest
  • Clean out empty manifest folders (should this be part of repair)
  • Clean out extra files in the manifest folders
  • Clean out installation records (how would this work with VS + SDK)
  • Clean up installed packs (similar question around msis and VS)

@sfoslund sfoslund removed their assignment Nov 29, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.2xx, 6.0.3xx Dec 11, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.3xx, 6.0.4xx Apr 13, 2022
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.4xx, Backlog Jul 27, 2022
@baronfel baronfel modified the milestones: Backlog, 8.0.1xx Jan 18, 2023
@nagilson nagilson self-assigned this Feb 2, 2023
nagilson added a commit that referenced this issue Feb 9, 2023
@marcpopMSFT marcpopMSFT added the User Story A single user-facing feature. Can be grouped under an epic. label Mar 17, 2023
@baronfel baronfel modified the milestone: 8.0.1xx Mar 17, 2023
@marcpopMSFT marcpopMSFT added Cost:S Less than 4 person weeks of work per central guidance Priority:1 Work that is critical for the release, but we could probably ship without labels Mar 17, 2023
JL03-Yue pushed a commit to JL03-Yue/sdk that referenced this issue May 26, 2023
@KieranFoot
Copy link

NOTE: This does not work with dev packages as for some reason their signatures are checked before any attempt to remove them is made. This is the same for dotnet workload uninstall and since MS makes no effort to make sure all dependencies exist in the DEV repo, or that they're published in any kind of reverse dependant order, workload updates and installs for dev packages regularly fail and render my development machine unusable, since there is no way to remove or even roll back the offending workloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads Cost:S Less than 4 person weeks of work per central guidance Priority:1 Work that is critical for the release, but we could probably ship without User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants