Prevent Microsoft.AspNetCore.App.Internal.Assets from being restored when not needed

[mthalman]

When running dotnet publish with self-contained deployment on a plain old web app, it causes the Microsoft.AspNetCore.App.Internal.Assets package to be restored from nuget.org even though that package isn't actually used by the deployed app it's not Blazor). This should be avoided because it's problematic when using a source built .NET SDK (see #46055 (comment)).

Repro steps:

1. Install a CentOS Stream 9 source built .NET 10 SDK
2. dotnet new webapp
3. dotnet publish --self-contained true -r centos.9-x64

This was found when attempting to enable the self-contained tests for the VMR: #46055

[ViktorHofer]

cc @javiercn @MackinnonBuck

[tmds]

Per @maraf's comment the package dependency is added based on UsingMicrosoftNETSdkRazor.

UsingMicrosoftNETSdkRazor is currently set on any ASP.NET Core project through the Microsoft.NET.Sdk.Web SDK.

Since this is a non source-buildable dependency which doesn't ship with a source-build SDK, we want to minimize the projects that depend on it.

cc @omajid

[MichaelSimons]

@javiercn, can you provide some guidance or refer to someone who can? TIA.

[tmds]

@javiercn ptal.

[javiercn]

Apologies, I thought we had addressed this, but I can't find the PR.

The plan is to only restore the package on the presence of .razor files in the project

[javiercn]

Correction. Not sure how but the history on the repo got completely botched. We fixed this a while back. There's a property
$(RequiresAspNetWebAssets) that is used to make this determination. It defaults to false and is only set in the presence of .razor files.

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets

Line 107 in 21c97bc

<RequiresAspNetWebAssets Condition="'$(RequiresAspNetWebAssets)' == ''">false</RequiresAspNetWebAssets>

sdk/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets

Line 113 in 21c97bc

<RequiresAspNetWebAssets Condition="'$(RequiresAspNetWebAssets)' == '' and @(Content->AnyHaveMetadataValue(Extension, .razor))">true</RequiresAspNetWebAssets>

I'm closing this, since the issue should be addressed, but let me know if the issue somehow persists for any reason we aren't able to see.